Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] rma_purchase_operating_unit #448

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

JasminSForgeFlow
Copy link
Collaborator

No description provided.

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-rma_purchase_operating_unit branch from 969593f to e2db00f Compare July 19, 2023 12:06
@AaronHForgeFlow
Copy link
Contributor

@JasminSForgeFlow can you fix this PR? It seems there are conflicts with another module, could you rebase and fix conflicts?

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-rma_purchase_operating_unit branch from e2db00f to b103a0f Compare September 26, 2023 09:10
@JasminSForgeFlow
Copy link
Collaborator Author

@JasminSForgeFlow can you fix this PR? It seems there are conflicts with another module, could you rebase and fix conflicts?

Fixed, Thanks

@AaronHForgeFlow
Copy link
Contributor

Github is telling me that there are conflicts in this PR. Can you check you rebase with the latest code?

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-rma_purchase_operating_unit branch from b103a0f to 651b0cf Compare September 28, 2023 03:17
@JasminSForgeFlow
Copy link
Collaborator Author

Github is telling me that there are conflicts in this PR. Can you check you rebase with the latest code?

I am not sure why there is a conflict even updating it. I have just follow migration process and pushed it so it is up to date now

@codecov-commenter
Copy link

Codecov Report

Merging #448 (651b0cf) into 15.0 (4e7ebc7) will decrease coverage by 0.03%.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             15.0     #448      +/-   ##
==========================================
- Coverage   80.68%   80.66%   -0.03%     
==========================================
  Files         144      147       +3     
  Lines        4830     4840      +10     
  Branches      754      754              
==========================================
+ Hits         3897     3904       +7     
- Misses        720      723       +3     
  Partials      213      213              
Files Coverage Δ
rma_purchase_operating_unit/__init__.py 100.00% <100.00%> (ø)
rma_purchase_operating_unit/wizards/__init__.py 100.00% <100.00%> (ø)
...ating_unit/wizards/rma_line_make_purchase_order.py 62.50% <62.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7ebc7...651b0cf. Read the comment docs.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works same as in previous versions.

I miss some features like filling in the OU in the RMA line when selecting a source PO, but that can be done in another PR.

@AaronHForgeFlow AaronHForgeFlow merged commit 7b0694f into 15.0 Sep 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants