Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] Added a better ux to select or write reason of refund #454

Merged
merged 1 commit into from
May 7, 2024

Conversation

ChrisOForgeFlow
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #454 (92b52e7) into 14.0 (fb9af9b) will decrease coverage by 0.06%.
The diff coverage is 64.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #454      +/-   ##
==========================================
- Coverage   80.67%   80.62%   -0.06%     
==========================================
  Files         156      156              
  Lines        4858     4871      +13     
  Branches      894      897       +3     
==========================================
+ Hits         3919     3927       +8     
- Misses        729      732       +3     
- Partials      210      212       +2     
Files Changed Coverage Δ
rma_account/wizards/rma_refund.py 80.90% <42.85%> (-2.59%) ⬇️
rma_refund_reason/wizard/rma_refund.py 78.57% <85.71%> (+3.57%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9af9b...92b52e7. Read the comment docs.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 14.0-fix-ref_credit_note_rma branch 3 times, most recently from 92b52e7 to b2b8c0a Compare September 19, 2023 14:15
@AaronHForgeFlow AaronHForgeFlow merged commit 8db0ee9 into 14.0 May 7, 2024
4 checks passed
@AaronHForgeFlow AaronHForgeFlow deleted the 14.0-fix-ref_credit_note_rma branch May 7, 2024 13:04
@AaronHForgeFlow
Copy link
Contributor

No need for the forward port, already ok in 15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants