-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16][ADD] rma_category #458
[16][ADD] rma_category #458
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #458 +/- ##
==========================================
+ Coverage 80.98% 81.04% +0.05%
==========================================
Files 124 128 +4
Lines 4807 4822 +15
Branches 779 779
==========================================
+ Hits 3893 3908 +15
Misses 701 701
Partials 213 213
Continue to review full report in Codecov by Sentry.
|
38a1411
to
24e7014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would appreciate a test, but as long as there is no logic we can skip that.
24e7014
to
b412811
Compare
Indeed, there are not logic at all, just a way to classify the RMA with a M2O. I would not know which test I could do for now ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM including the fix in RMA view. Can you please put the RMA change in a separate commit? Also, the readme won't be created automatically by the content in the readme folder, so I am afraid you have to do it :'(
b412811
to
336dbe5
Compare
I did a separate commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @florian-dacosta
Well, pre-commit fails suddenly, I have no idea why... |
I will check that, perhaps we have to update pre-commit version |
It seems related to change in python version in github actions: |
@florian-dacosta if you rebase it should be green now. |
336dbe5
to
8bcda1c
Compare
Great, thanks ! |
Add the possibility to add one or more categories on RMA