Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #22

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Testing #22

merged 7 commits into from
Jun 7, 2024

Conversation

lsoucasse
Copy link
Member

@lsoucasse lsoucasse commented Jun 4, 2024

This work adds two tests to Janus based on the two demo files (instellation and runaway_greenhouse): it basically checks all the computed values with previous ones with a given tolerance. A GitHub action is set up to run them using pytest for each push/pull request.

This should close issue #21 and #19 .

The demo scripts and the main Janus script (SocRadConv.py) are now in the examples folder. We can turn them into notebook tutorials potentially.

@lsoucasse lsoucasse linked an issue Jun 4, 2024 that may be closed by this pull request
@nichollsh
Copy link
Contributor

Looks great. Might be better to have the workflows run on either push or PR, not both. Seems redundant to have them both running.

I think that testing the runaway greenhouse is good, as well as this energy balance script. They both cover a wide temperature range, and are pretty key to the simulations.

@lsoucasse
Copy link
Member Author

Looks great. Might be better to have the workflows run on either push or PR, not both. Seems redundant to have them both running.

I think that testing the runaway greenhouse is good, as well as this energy balance script. They both cover a wide temperature range, and are pretty key to the simulations.

Thanks for your feedback Harrison. I like having the tests running at each push, so that it is easier to spot potential problems. I agree then running tests at PR is redundant but to me it does not hurt.

@nichollsh
Copy link
Contributor

Fair enough. I think that moving SocRadConv.py into examples/ makes sense too - since it's more of an executable than an importable part of the package.

@lsoucasse lsoucasse merged commit bf3ebed into master Jun 7, 2024
6 checks passed
@lsoucasse lsoucasse deleted the testing branch June 7, 2024 06:51
lsoucasse added a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing JANUS
2 participants