Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up coverage testing #40

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Set up coverage testing #40

merged 6 commits into from
Jul 23, 2024

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Jul 23, 2024 •
edited
Loading

This PR sets up coverage testing. I updated CONTRIBUTING.md with how to get started. The test workflow will report the coverage to the action artifacts and as a badge in the readme.

See: https://github.com/FormingWorlds/JANUS/blob/coverage/README.md

TODO

  • Add GIST_TOKEN to secrets

@timlichtenberg
Copy link
Collaborator

Gave you access to administrative actions on JANUS. Sufficient?

@stefsmeets stefsmeets marked this pull request as ready for review July 23, 2024 09:32
@stefsmeets
Copy link
Contributor Author

Thanks @timlichtenberg , should be good now! Would you be willing to review this?

@timlichtenberg
Copy link
Collaborator

Sure, since Laurent is not here this week though, it will be good if also @nichollsh has a look on your PRs this week. We should discuss PR organisation at one of the next PROTEUS meetings.

nichollsh
nichollsh approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@nichollsh nichollsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Getting some ideas as to the code coverage will be useful, and should probably also be done for PROTEUS at some point in the future too.

timlichtenberg
timlichtenberg approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@timlichtenberg timlichtenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, looks good to me.

@stefsmeets stefsmeets merged commit f53287a into master Jul 23, 2024
6 checks passed
@stefsmeets stefsmeets deleted the coverage branch July 23, 2024 11:24
@stefsmeets stefsmeets mentioned this pull request Jul 23, 2024
Closed
@stefsmeets
Copy link
Contributor Author

Example coverage: https://github.com/FormingWorlds/JANUS/actions/runs/10061102573#summary-27810317683

lsoucasse pushed a commit that referenced this pull request Sep 24, 2024
@timlichtenberg
Merge pull request #40 from FormingWorlds/recent_fixes
8e040e5 
Spectral files, water tables, runaway OLR curves, and other changes
lsoucasse pushed a commit that referenced this pull request Sep 24, 2024
@stefsmeets
Merge pull request #40 from FormingWorlds/coverage
b7e357f 
Set up coverage testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichollsh nichollsh nichollsh approved these changes

@timlichtenberg timlichtenberg timlichtenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefsmeets @timlichtenberg @nichollsh