Download tool for spectral / stellar data #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichollsh
approved these changes
Jul 24, 2024
lsoucasse
pushed a commit
that referenced
this pull request
Sep 24, 2024
Conductive skin parameterisation, and other major changes.
lsoucasse
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Add click based download tool for spectral/stellar files * Update readme * Refactor download tool to avoid sending excess requests * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we discussed this at some point, but I'm interested in exploring the possibility of having a tool that can easily download the stellar / spectral data for JANUS. And later, the SOCRATES build files.
I also refactored the dowload code, so it reduces the number of requests by a up to 6x. This makes a big difference when pulling all stellar data:
Before: 245.13 secs
After: 84.61 secs
Usage:
janus download spectraljanus download stellar