Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for PROTEUS #149

Merged
merged 22 commits into from
Aug 27, 2024
Merged

Add integration test for PROTEUS #149

merged 22 commits into from
Aug 27, 2024

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Aug 26, 2024

This PR adds an integration test for PROTEUS using the dummy config. This bumps the coverage to about 60%. It takes about 40 seconds on my PC.

I tried the default config (with JANUS), but this is extremely slow (over 6 min) even with max_iter=0. I think it would be better to test this module and others separately, or once we have a better way to control the number of iterations.

TODO

  • Fix CI workflow

@stefsmeets stefsmeets marked this pull request as ready for review August 26, 2024 14:01
@stefsmeets
Copy link
Contributor Author

stefsmeets commented Aug 27, 2024

I tried to get the integration test to work on the CI, but the installation procedure is too complicated, because several tools need to be compiled from scratch (most notably PETSC with SUNDIALS support for SPIDER). This already took close to 30 minutes. This makes the workflow incredibly painful to set up, debug and maintain, so I chose to skip the integration test in the CI. The test runs fine locally.

@stefsmeets stefsmeets requested a review from nichollsh August 27, 2024 08:46
@stefsmeets
Copy link
Contributor Author

stefsmeets commented Aug 27, 2024

@nichollsh @lsoucasse would you care to have a look at this PR and let me know what you think?

@stefsmeets stefsmeets requested a review from lsoucasse August 27, 2024 13:20
@nichollsh
Copy link
Contributor

I don't understand why the model takes >6 minutes with JANUS, but this is something to be investigated separately. If it works fine with the dummy config then that's good for now.

Copy link
Contributor

@nichollsh nichollsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Really nice to finally have some tests in PROTEUS itself.

@lsoucasse
Copy link
Member

Very nice to have this test set up! I just notice that the workflow install Mors and Janus from current master branch status (without using it though) while we rather want to install a specific version. But this will be fixed soon when we install them through the package dependencies after making the appropriate releases.

@stefsmeets
Copy link
Contributor Author

stefsmeets commented Aug 27, 2024

@lsoucasse Exactly! And pulling all the submodules takes a while, whereas mors and janus are fairly light, so I did it this way anticipating that the packages will soon change anyway and we use some code from the development version.

@stefsmeets stefsmeets merged commit fa0363a into master Aug 27, 2024
2 checks passed
@stefsmeets stefsmeets deleted the integration-test branch August 27, 2024 15:18
@stefsmeets stefsmeets mentioned this pull request Aug 29, 2024
@stefsmeets stefsmeets mentioned this pull request Sep 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants