Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate escape config #290

Merged
merged 10 commits into from
Nov 25, 2024
Merged

Validate escape config #290

merged 10 commits into from
Nov 25, 2024

Conversation

nichollsh
Copy link
Contributor

@nichollsh nichollsh commented Nov 25, 2024

Set p_xuv and z_xuv to surface when ZEPHYRUS is disabled. Closes #286 and #258

Ensure that configuration uses MORS+Spada when ZEPHYRUS is enabled. Related to #232.

Avoid spurious values for period in first iteration. Calculation of this quantity depends on M_star, which is undefined when period is first calculated, and can cause some strange behaviour. Fixed this by ensuring that M_star is always defined.

@nichollsh nichollsh marked this pull request as ready for review November 25, 2024 13:53
Copy link
Contributor

@EmmaPostolec EmmaPostolec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Harrison, very nice job ! The condition on Pxuv computation is really nice to save some computational time. Also, very nice idea to create the get_heigh_from_pressure function, very effective. Thanks for introducing error message also for the user. The computation of mu in the orbit/wrapper.py is not really linked to this issue ?

@nichollsh
Copy link
Contributor Author

Thanks Emma! The issue with mu is something that's slightly odd. I noticed that the tests sometimes fail with MacOS, even though they succeed on my PC. I think this is because of this period parameter being set by some undefined behaviour.

@EmmaPostolec
Copy link
Contributor

Also I think this PR is linked to #258 ?

@nichollsh
Copy link
Contributor Author

Yes! It is. I didn't notice this issue, thanks Emma.

@EmmaPostolec
Copy link
Contributor

No worries! I assigned myself this task but you did it faster than me :)

@lsoucasse
Copy link
Member

I happy with these changes. You can merge them now Harrison so that I can update and merge my current PR afterwards.

@nichollsh
Copy link
Contributor Author

Ah okay, sure! Thanks Laurent.

@nichollsh nichollsh merged commit e488c46 into main Nov 25, 2024
5 checks passed
@nichollsh nichollsh deleted the hn/escape_valid branch November 25, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't set escape level when escape is disabled
3 participants