-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate escape config #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Harrison, very nice job ! The condition on Pxuv computation is really nice to save some computational time. Also, very nice idea to create the get_heigh_from_pressure function, very effective. Thanks for introducing error message also for the user. The computation of mu in the orbit/wrapper.py is not really linked to this issue ?
Thanks Emma! The issue with mu is something that's slightly odd. I noticed that the tests sometimes fail with MacOS, even though they succeed on my PC. I think this is because of this |
Also I think this PR is linked to #258 ? |
Yes! It is. I didn't notice this issue, thanks Emma. |
No worries! I assigned myself this task but you did it faster than me :) |
…sts with new value first iter. Upload helpfile as artefact on failure
I happy with these changes. You can merge them now Harrison so that I can update and merge my current PR afterwards. |
Ah okay, sure! Thanks Laurent. |
Set
p_xuv
andz_xuv
to surface when ZEPHYRUS is disabled. Closes #286 and #258Ensure that configuration uses MORS+Spada when ZEPHYRUS is enabled. Related to #232.
Avoid spurious values for
period
in first iteration. Calculation of this quantity depends onM_star
, which is undefined whenperiod
is first calculated, and can cause some strange behaviour. Fixed this by ensuring thatM_star
is always defined.