Fixes for video auto pause/play when thread switching.

Need to only start videos that are [autostart][muted] and to remove the special click handling of attachment videos which is now a generic function of the Message view.
ForstaLabs · Jan 31, 2018 · a433019 · a433019
1 parent 1bb289f
commit a433019
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/app/views/attachment.js b/app/views/attachment.js
@@ -159,9 +159,7 @@
         onClick: function(e) {
             switch (this.contentType) {
                 case 'audio':
-                    break;
                 case 'video':
-                    e.target.paused ? e.target.play() : e.target.pause();
                     break;
                 case 'image':
                     this.handleImageModal();

diff --git a/app/views/conversation.js b/app/views/conversation.js
@@ -69,9 +69,9 @@
         },
 
         onClosed: function(e) {
-            this.$('video').each(function() {
-                this.pause();
-            });
+            for (const video of this.$('video')) {
+                video.pause();
+            }
         },
 
         onTitleClick: function(ev) {
@@ -157,17 +157,17 @@
             }
         },
 
-        onOpened: function() {
+        onOpened: async function() {
             this.msgView.scrollRestore();
             this.focusMessageField();
             this.model.markRead();
-            this.$('video').each(function() {
+            for (const video of this.$('video[autoplay][muted]')) {
                 try {
-                    this.play();
+                    await video.play();
                 } catch(e) {
-                    console.warn("Ignore video play error:", e);
+                    console.debug("Ignore video play error:", e);
                 }
-            });
+            }
         },
 
         focusMessageField: function() {