Use empty function to check if phone number handle is set

FosterCommerce · Oct 2, 2023 · 1053323 · 1053323
1 parent 4c4ae3c
commit 1053323
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/services/Xml.php b/src/services/Xml.php
@@ -351,9 +351,9 @@ private function generateName($firstName, $lastName): ?string
 
         $names = [$firstName, $lastName];
         $names = array_filter(
-            $names, 
-            function($name) { 
-                return $name !== null && $name !== ''; 
+            $names,
+            function($name) {
+                return $name !== null && $name !== '';
             }
         );
 
@@ -453,8 +453,8 @@ public function address(\SimpleXMLElement $xml, Address $address=null, $name='Ad
                 */
                 'Country' => 'countryCode',
             ];
-            
-            if($settings->phoneNumberFieldHandle != '' && $settings->phoneNumberFieldHandle != null){
+
+            if(!empty($settings->phoneNumberFieldHandle)){
                 $address_mapping['Phone'] = $settings->phoneNumberFieldHandle;
             }