Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Kafka Unit Testing Issues #8

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
1 change: 0 additions & 1 deletion src/Foundatio.Kafka/Messaging/KafkaMessageBus.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ private async Task OnMessageAsync(IConsumer<string, byte[]> consumer, ConsumeRes

// What to do if message type is null?
var message = ConvertToMessage(messageType, consumeResult.Message);

await SendMessageToSubscribersAsync(message).AnyContext();

if (!_subscribers.IsEmpty)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ protected override IMessageBus GetMessageBus(Func<SharedMessageBusOptions, Share
);
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task CanReceiveFromMultipleSubscribersAsync()
{
return base.CanReceiveFromMultipleSubscribersAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task CanReceiveMessagesConcurrentlyAsync()
{
return base.CanReceiveMessagesConcurrentlyAsync();
Expand Down
16 changes: 8 additions & 8 deletions tests/Foundatio.Kafka.Tests/Messaging/KafkaMessageBusTests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Threading;
using System.Threading.Tasks;
using Foundatio.AsyncEx;
Expand All @@ -21,7 +21,7 @@ public override Task CanUseMessageOptionsAsync()
return base.CanUseMessageOptionsAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task CanSendMessageAsync()
{
return base.CanSendMessageAsync();
Expand All @@ -33,7 +33,7 @@ public override Task CanHandleNullMessageAsync()
return base.CanHandleNullMessageAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task CanSendDerivedMessageAsync()
{
return base.CanSendDerivedMessageAsync();
Expand All @@ -45,13 +45,13 @@ public override Task CanSendDelayedMessageAsync()
return base.CanSendDelayedMessageAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task WillReceiveDerivedMessageTypesAsync()
{
return base.WillReceiveDerivedMessageTypesAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task CanSubscribeToAllMessageTypesAsync()
{
return base.CanSubscribeToAllMessageTypesAsync();
Expand All @@ -63,7 +63,7 @@ public override Task CanSubscribeToRawMessagesAsync()
return base.CanSubscribeToRawMessagesAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task CanTolerateSubscriberFailureAsync()
{
return base.CanTolerateSubscriberFailureAsync();
Expand All @@ -75,13 +75,13 @@ public override Task CanSendMessageToMultipleSubscribersAsync()
return base.CanSendMessageToMultipleSubscribersAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task CanSubscribeConcurrentlyAsync()
{
return base.CanSubscribeConcurrentlyAsync();
}

[Fact(Skip = "https://github.com/confluentinc/confluent-kafka-dotnet/issues/1832")]
[Fact]
public override Task WillOnlyReceiveSubscribedMessageTypeAsync()
{
return base.WillOnlyReceiveSubscribedMessageTypeAsync();
Expand Down
Loading