-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the internal Pod map and use the controller runtime cache #1637
Merged
johscheuer
merged 1 commit into
FoundationDB:main
from
johscheuer:remove-the-internal-pod-map
May 22, 2023
Merged
Remove the internal Pod map and use the controller runtime cache #1637
johscheuer
merged 1 commit into
FoundationDB:main
from
johscheuer:remove-the-internal-pod-map
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7
|
sbodagala
reviewed
May 19, 2023
sbodagala
reviewed
May 19, 2023
If there is already a controller run-time cache it makes sense to use that rather than building another index with the same functionality. |
sbodagala
approved these changes
May 19, 2023
b7a936c
to
053761c
Compare
johscheuer
commented
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased to the latest changes in main. Once the pipeline completes successfully I'm going to merge it.
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1612
For large clusters it will be more efficient to use the controller-runtime cache directly instead of doing a list and then building our own cache on top of the controller-runtime cache.
Type of change
Please select one of the options below.
Discussion
This is a breaking change as we extend the
PodLifecycleManager
interface.Testing
Adjusted unit tests and e2e tests will be running.
Documentation
Follow-up
Could be: #1619 to make sure we reduce the number of conversions and parsing in our operator.