Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the internal Pod map and use the controller runtime cache #1637

Merged

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1612

For large clusters it will be more efficient to use the controller-runtime cache directly instead of doing a list and then building our own cache on top of the controller-runtime cache.

Type of change

Please select one of the options below.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Discussion

This is a breaking change as we extend the PodLifecycleManager interface.

Testing

Adjusted unit tests and e2e tests will be running.

Documentation

Follow-up

Could be: #1619 to make sure we reduce the number of conversions and parsing in our operator.

@johscheuer johscheuer added the enhancement New feature or request label May 17, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b7a936c4b1d39f18a6114e0d20e3844cf4156476
  • Duration 3:08:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7

  • Commit ID: b7a936c4b1d39f18a6114e0d20e3844cf4156476
  • Duration 4:12:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@sbodagala
Copy link
Contributor

If there is already a controller run-time cache it makes sense to use that rather than building another index with the same functionality.

@johscheuer johscheuer force-pushed the remove-the-internal-pod-map branch from b7a936c to 053761c Compare May 22, 2023 07:20
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to the latest changes in main. Once the pipeline completes successfully I'm going to merge it.

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 053761c
  • Duration 3:24:31
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 68e2c46 into FoundationDB:main May 22, 2023
@johscheuer johscheuer deleted the remove-the-internal-pod-map branch May 22, 2023 10:52
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7

  • Commit ID: 053761c
  • Duration 4:12:26
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink the current usage of the cache and map mapping for Pods and other resources
3 participants