Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.4 #95

Open
wants to merge 6 commits into
base: 1.18.2
Choose a base branch
from
Open

Version 0.4 #95

wants to merge 6 commits into from

Conversation

Jog-Ming
Copy link

  • Updated gradle wrapper, fabric loom, fabric loader, fabric api, arrp, and maven repositories
  • Fixed a mixin warning

Jog-Ming added 6 commits July 9, 2024 16:00
- Update to java 17
- Update to fabric 0.77.0
- Update to arrp 0.5.7
- Fixed a mixin warning
- Update to gradle wrapper 8.8
- Update to fabric loom 1.7.2
- Updated maven repositories
- Fixed server crash on AutomobileAssembler placement
- Fixed server crash on Automobile placement
- Fixed server crash on Automobile Assembly
- Downgraded to fabric loom 1.5
Copy link

@ajh123 ajh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why as the @Environment(EnvType.CLIENT) annotation been removed from a bunch of files? Models are a client only thing, so having this annotation will prevent them from being used on the server.

@Jog-Ming
Copy link
Author

Jog-Ming commented Jan 24, 2025

Because the game crashes if they are not removed. Somehow the server references these fields even though they are supposed to be client only.

I updated the mod because I was trying to install this mod on a 1.18.2 server that have other mods that require the latest version of fabric api. So I am quite certain that not removing these annotations actually crashes the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants