Create fr_fr.json #106
Create fr_fr.json #106
Conversation
French translation for Sandwichable on 1.17
|
|
||
| © 2021 GitHub, Inc. | ||
| Terms | ||
| Privacy | ||
| Security | ||
| Status | ||
| Docs | ||
|
|
||
| Contact GitHub | ||
| Pricing | ||
| API | ||
| Training | ||
| Blog | ||
| About |
There was a problem hiding this comment.
This appears to be a mistake where too much was copied when copying a template for the lang file. As it is the footer of GitHub.
| © 2021 GitHub, Inc. | |
| Terms | |
| Privacy | |
| Security | |
| Status | |
| Docs | |
| Contact GitHub | |
| Pricing | |
| API | |
| Training | |
| Blog | |
| About |
There was a problem hiding this comment.
So I need to remove this footer and it will be okay ? (Sorry, real noob here...)
There was a problem hiding this comment.
Yes, at least the file. I have not verified the actual translations since I don't speak french. Use en_us.json for reference. The closing curly bracket should be the last line of the file.
|
Like this? I've use the en_us.json for the first one too, I don't where it found those last line. I remove them manualy on the file. Would it have done the same thing if I had clicked on "Add suggestion to batch" or it is for something else? Thank you for your help and your correction ! |
|
Yes, that fixes it. The "Add suggestion to batch" would of done the same thing for the most part. It's used so you can put all of the requested changes you accept into the same commit automatically and it adds the people who suggested the change as co-authors. I think you got those lines because you copied the file from a browser tab and it highlighted the bottom row of the webpage so it got copied. |
|
Ow sorry, your name will not be add as co-author 'cause I changed it manualy... Thanks again for your help and explanations, realy appreciate it! |
|
Hello, the 1.17 branch is not actually updated to 1.17 - it is equivalent to the indev branch. |
|
Okay, I'll try to pass this one on "indev" so you'll can have the current translation up-to-date anyway ! Sorry to have bothered the pulls with all my translations' pull request... |
French translation for Sandwichable on 1.17
As I did for the previous version, I made a new french translation for the 1.17 version.
I hope it'll work great, I never did any "pull request" before and there's not a lot of explications/tutorials in french about it. Sorry if I did it wrong ! Just tell me and I'll correct it right.
Hope it will help you !