Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sign error for mean meridional PV gradient Qy in MultiLayerQG module #329

Merged
merged 21 commits into from
Jun 11, 2023
Merged

Fixing sign error for mean meridional PV gradient Qy in MultiLayerQG module #329

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6416286
changed reduced gravity to have const. denominator
Jun 9, 2023
04ee8fe
changed sign of Fp in multi layer Qy calc, line 367
Jun 9, 2023
67a701f
Merge pull request #1 from mjclobo/matts_dev
mjclobo Jun 9, 2023
427cdff
reverting to old definition of reduced grav to test bug fix with sign…
Jun 9, 2023
3072ef2
Merge pull request #2 from mjclobo/matts_dev
mjclobo Jun 9, 2023
3ce77d3
alternate (but still incorrect) definition of reduced gravity (shifte…
Jun 9, 2023
d619644
Merge branch 'matts_dev' into main
Jun 9, 2023
b9098ce
changed sign error, but leaving reduced grav; just to create pull req…
Jun 9, 2023
a7509bd
changing things so that I only have the sign error fixed, to create p…
Jun 9, 2023
96add48
changing reduced grav definition to match current one in main repo
Jun 9, 2023
cd6f29e
changing reduced gravity definition...hopefully last time
Jun 9, 2023
e55544f
fixing merge conflict
Jun 9, 2023
25a1d73
trying to fix reduced gravity merge conflict :')
Jun 9, 2023
0ec43c6
remove backup files
Jun 9, 2023
40691ca
adding examples for GFjl issue
Jun 9, 2023
9857257
fixed sign error in multilayerqg.jl ONLY
Jun 9, 2023
ef43c78
removed various multilayerqg files in src
Jun 9, 2023
957805e
Update Project.toml
mjclobo Jun 9, 2023
80364d0
add nonlinear advection test for 3 layers
navidcy Jun 10, 2023
38e3317
simplify tests
navidcy Jun 10, 2023
76f31c9
Merge branch 'main' into sign_error_fix
navidcy Jun 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Project.toml 
Updating version number for patch release
  • Loading branch information
@mjclobo
mjclobo authored Jun 9, 2023
commit 957805e3351a77fe37141f259d27bb69d31f20bd
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = "GeophysicalFlows"
uuid = "44ee3b1c-bc02-53fa-8355-8e347616e15e"
license = "MIT"
authors = ["Navid C. Constantinou <navidcy@gmail.com>", "Gregory L. Wagner <wagner.greg@gmail.com>", "and co-contributors"]
version = "0.15.2"
version = "0.15.3"

[deps]
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
Expand Down