Skip to content

Commit

Permalink
fix warnings on mac (#139)
Browse files Browse the repository at this point in the history
* fixed Ja4x errors, warnings and built new binary for windows

* fix warnings on mac
  • Loading branch information
noeltimothy authored Aug 5, 2024
1 parent 2f0cc26 commit dff93de
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions wireshark/source/packet-ja4.c
Original file line number Diff line number Diff line change
Expand Up @@ -928,8 +928,8 @@ dissect_ja4(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree, void *dummy
//BUG-FIX: Ja4x should use Hex codes instead of ascii
const guint8 *bytes = fvalue_get_bytes_data(field->value);
gsize size = g_bytes_get_size(fvalue_get_bytes(field->value));
for (int i=0; i<size; i++) {
wmem_strbuf_append_printf(current_cert->oids[oid_type], "%02x", bytes[i]);
for (int j=0; j< (int)size; j++) {
wmem_strbuf_append_printf(current_cert->oids[oid_type], "%02x", bytes[j]);
}
wmem_strbuf_append_printf(current_cert->oids[oid_type], "%x", 0);
}
Expand All @@ -939,8 +939,8 @@ dissect_ja4(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree, void *dummy
//BUG-FIX: Ja4x should use Hex codes instead of ascii
const guint8 *bytes = fvalue_get_bytes_data(field->value);
gsize size = g_bytes_get_size(fvalue_get_bytes(field->value));
for (int i=0; i<size; i++) {
wmem_strbuf_append_printf(current_cert->oids[oid_type], "%02x", bytes[i]);
for (int j=0; j< (int)size; j++) {
wmem_strbuf_append_printf(current_cert->oids[oid_type], "%02x", bytes[j]);
}
wmem_strbuf_append_printf(current_cert->oids[oid_type], "%x", 0);
}
Expand Down

0 comments on commit dff93de

Please sign in to comment.