Skip to content

Commit

Permalink
fix for #40
Browse files Browse the repository at this point in the history
  • Loading branch information
noeltimothy committed Jan 24, 2024
1 parent 2a8c08b commit ee63b26
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion python/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def get_hex_sorted(entry, field, sort=True):
actual_length = len(c)

# now remove SNI and ALPN values
if field == 'extensions':
if field == 'extensions' and sort:
c = [ x for x in c if x not in ['0000', '0010']]

c.sort() if sort else None
Expand Down
3 changes: 0 additions & 3 deletions python/ja4.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,6 @@ def to_ja4(x, debug_stream):
cache_update(x, 'client_ciphers', x['ciphers'], debug_stream)

x['signature_algorithms'] = [ y[2:] for y in get_signature_algorithms(x) ]

# ignore SNI and ALPN extensions
x['extensions'] = [ x for x in x['extensions'] if x not in ['0x0000', '0x0010'] ]
cache_update(x, 'client_extensions', x['extensions'], debug_stream)

# Modified to include original rendering
Expand Down

0 comments on commit ee63b26

Please sign in to comment.