Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireshark crash fixes for 4.4 #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Boolean263
Copy link
Contributor

Fix a crash when fetching ssh.direction caused by using the wrong function in #128. fvalue_get_uinteger() doesn't support the FT_BOOLEAN field, but fvalue_get_uinteger64() does.

Fix a crash in locate_tree() when the first child of the passed-in tree is non-null but has a null finfo member.

These fixes allow the plugin to pass the test suite on the current main branch (master) of Wireshark when built as an in-tree plugin.

Fix a crash when fetching `ssh.direction` caused by using the wrong
function in FoxIO-LLC#128. `fvalue_get_uinteger()` doesn't support the
`FT_BOOLEAN` field, but `fvalue_get_uinteger64()` does.

Fix a crash in `locate_tree()` when the first child of the passed-in
tree is non-null but has a null `finfo` member.

These fixes allow the plugin to pass the test suite on the current main
branch (`master`) of Wireshark when built as an in-tree plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant