[fix] JA4L: Handle "impure" TCP flags #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug report: FoxIO-LLC#22
vvv
commented
Nov 9, 2023
Comment on lines
-379
to
-391
| /// A fingerprint that was obtained from a single packet. | ||
| /// | ||
| /// `PacketFingerprint` can represent JA4 (TLS client), JA4S (TLS server), or | ||
| /// JA4H (HTTP client) fingerprint. Other types of fingerprints are derived from | ||
| /// multiple packets. | ||
| #[derive(Debug, Serialize)] | ||
| // HACK: Use a configuration parameter to enable serialization of packet numbers. | ||
| #[cfg_attr(not(debug_assertions), serde(transparent))] | ||
| struct PacketFingerprint { | ||
| #[cfg_attr(not(debug_assertions), serde(skip_serializing), allow(dead_code))] | ||
| packet: PacketNum, | ||
| fp: String, | ||
| } |
There was a problem hiding this comment.
Dead code. I'm surprised that neither compiler nor clippy were able to detect it.
Comment on lines
+14
to
+15
| ja4l_c: 62_64 | ||
| ja4l_s: 17255_63 |
There was a problem hiding this comment.
Previous version (0.15.1) wouldn't generate these JA4L fingerprints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug report: #22