Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]LogObjectNotFound not implemented correctly #184

Open
Holgerhollebolle opened this issue May 14, 2024 · 7 comments · May be fixed by #186
Open

[BUG]LogObjectNotFound not implemented correctly #184

Holgerhollebolle opened this issue May 14, 2024 · 7 comments · May be fixed by #186
Assignees
Labels
bug Something isn't working change Task
Milestone

Comments

@Holgerhollebolle
Copy link

Describe the bug
I was happy to see you implemented the LogObjectNotFound option in Faster.
Unfortunatly it does not work. You need to implement it as a class called AdvancedOptions. In the Server.cfg needs to be:


class AdvancedOptions
{
    LogObjectNotFound = false;
};

To Reproduce
You can reproduce it by running any mission on a server and check the log. There should be no Object not found messeges...but there still are these messages.

Screenshots
This is how it does work when you enter the code in the Mission selecto overwrite
image

OS Version (required):

  • OS: Windows 10
  • FASTER Version 1.9e
@jupster jupster added the bug Something isn't working label May 14, 2024
@jupster
Copy link
Collaborator

jupster commented May 14, 2024

Known issue, unfortunately. I am still to find a way to implement it properly. I'll try and look into it this month

@Holgerhollebolle
Copy link
Author

Known issue, unfortunately. I am still to find a way to implement it properly. I'll try and look into it this month

Thanks for looking into it. As Is said above...if you define a class called AdvancedOptions it works here.

@jupster
Copy link
Collaborator

jupster commented May 15, 2024

I have done half the Job... i think 😅 now test, then just to make the output work again 😭

@jupster jupster self-assigned this May 15, 2024
@jupster jupster added this to the 1.9 milestone May 15, 2024
@jupster jupster linked a pull request May 28, 2024 that will close this issue
7 tasks
@jupster jupster linked a pull request May 28, 2024 that will close this issue
7 tasks
@Holgerhollebolle
Copy link
Author

Are there news On this @jupster ? Dont want to stress...just asking. With the Mission Overwrite like in the Screenshot it works. So it should be doable.

@jupster
Copy link
Collaborator

jupster commented Jun 26, 2024

Sorry disappeared for a little as life got pretty crazy.

I have implemented it but the output is a little annoying as it doesn't update and save probably. I'll see if I can't put a test build on my repo in the next day or two

@Holgerhollebolle
Copy link
Author

@

Sorry disappeared for a little as life got pretty crazy.

I have implemented it but the output is a little annoying as it doesn't update and save probably. I'll see if I can't put a test build on my repo in the next day or two

Great...thanks for the respond. I hope you will get it working....Keep up the good work but remember real life is more important. ;-)

@jupster
Copy link
Collaborator

jupster commented Jun 26, 2024

@Holgerhollebolle Don't blame me if something breaks https://github.com/jupster/FASTER1.9/releases/tag/1.9e.4

back up your files just in-case, if you want to test it. But let me know how it goes if you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working change Task
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

2 participants