Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various LINQ optimizations #195

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Various LINQ optimizations #195

merged 3 commits into from
Sep 30, 2024

Conversation

liamcannon
Copy link
Contributor

Replaced FirstOrDefault with Find where possible to optimize search, same with Exists over Any

Motivation and Context

How Has This Been Tested?

Functionally there are no breaking changes, all changes were optimizations

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@liamcannon
various LINQ optimizations to prefer find or firstordefault, Exists o…
84f4710 
…ver any where applicatble, changed Datetime(1970, 1, 1) to Datetime.UnixEpoch
@liamcannon liamcannon marked this pull request as ready for review September 27, 2024 03:00
@liamcannon
Copy link
Contributor Author

@jupster this is good for review

@jupster jupster merged commit b888dd7 into Foxlider:master Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liamcannon liamcannon

Labels
optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamcannon @jupster