sonarcloud improve code

FraunhoferIOSB · Aug 22, 2024 · 4f5e5bf · 4f5e5bf
1 parent 725f8e6
commit 4f5e5bf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/.../main/java/de/fraunhofer/iosb/ilt/faaast/registry/jpa/util/ModelTransformationHelper.java b/.../main/java/de/fraunhofer/iosb/ilt/faaast/registry/jpa/util/ModelTransformationHelper.java
@@ -80,10 +80,9 @@ public static JpaAssetAdministrationShellDescriptor convertAAS(AssetAdministrati
         if (aas == null) {
             return null;
         }
-        JpaAssetAdministrationShellDescriptor retval = new JpaAssetAdministrationShellDescriptor.Builder()
+        return new JpaAssetAdministrationShellDescriptor.Builder()
                 .from(aas)
                 .build();
-        return retval;
     }
 
 

diff --git a/...mory/src/main/java/de/fraunhofer/iosb/ilt/faaast/registry/memory/AasRepositoryMemory.java b/...mory/src/main/java/de/fraunhofer/iosb/ilt/faaast/registry/memory/AasRepositoryMemory.java
@@ -188,25 +188,21 @@ private AssetAdministrationShellDescriptor fetchAAS(String aasId) {
 
 
     private static boolean filterAssetType(AssetAdministrationShellDescriptor aas, String assetType) {
-        boolean retval;
         if (assetType == null) {
-            retval = true;
+            return true;
         }
         else {
-            retval = aas.getAssetType().equals(assetType);
+            return aas.getAssetType().equals(assetType);
         }
-        return retval;
     }
 
 
     private static boolean filterAssetKind(AssetAdministrationShellDescriptor aas, AssetKind assetKind) {
-        boolean retval;
         if (assetKind == null) {
-            retval = true;
+            return true;
         }
         else {
-            retval = aas.getAssetKind() == assetKind;
+            return aas.getAssetKind() == assetKind;
         }
-        return retval;
     }
 }