Wire solana #53
Open
Wire solana #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegahcarter
reviewed
Feb 23, 2025
package.json
Outdated
| "@nomicfoundation/hardhat-ethers": "^3.0.5", | ||
| "@nomiclabs/hardhat-ethers": "^2.2.3", | ||
| "@nomiclabs/hardhat-waffle": "^2.0.6", | ||
| "@openzeppelin/contracts": "^5.0.2", |
There was a problem hiding this comment.
This upgraded dependency will cause breaking changes in the OFT imports as the OFT uses 4.x.
pegahcarter
reviewed
Feb 25, 2025
pegahcarter
reviewed
Feb 27, 2025
pegahcarter
reviewed
Feb 27, 2025
pegahcarter
reviewed
Mar 3, 2025
| peerArray[2] = peer.sFrxEth; | ||
| peerArray[3] = peer.frax; | ||
| peerArray[4] = peer.frxEth; | ||
| peerArray[1] = peer.sFrxEth; // TODO: modify to sfrxUSD |
pegahcarter
reviewed
Mar 3, 2025
| bytes32 frxEth; | ||
| bytes32 fxs; | ||
| bytes32 sFrax; | ||
| bytes32 sfrxUSD; |
There was a problem hiding this comment.
Note the difference between this line and the next of sfrx and sFrx. Execution would be the same either way due to sorting, no change needed.
|
I've confirmed the msig txs. Question I have: what will the operations look like to add support to a new chain (say Base)? I noticed that in each wire commit (for example 303e427), the |
pegahcarter
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.