Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to 2025 WPILib #145

Merged
merged 30 commits into from
Jan 15, 2025
Merged

Update code to 2025 WPILib #145

merged 30 commits into from
Jan 15, 2025

Conversation

txrnqt
Copy link
Contributor

@txrnqt txrnqt commented Jan 14, 2025

updated code to 2025

@txrnqt txrnqt linked an issue Jan 14, 2025 that may be closed by this pull request
8 tasks
@txrnqt txrnqt closed this Jan 14, 2025
@txrnqt txrnqt reopened this Jan 14, 2025
@legoguy1000 legoguy1000 changed the title Update code to 2025 wipilib Update code to 2025 WPILib Jan 14, 2025
Copy link
Member

@legoguy1000 legoguy1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice job. a bunch of little things. Also IDK why the linting job didn't fail for u but go through the changes in the PR tab and you'll see all the comments it left for u to fix. It should have failed

akit_23ae23257838dd9a.wpilog Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
simgui-ds.json Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/swerve/Swerve.java Outdated Show resolved Hide resolved
Copy link
Member

@legoguy1000 legoguy1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at https://github.com/Frc5572/FRC2024/actions/runs/12775376178/job/35611620622#step:4:1 this should be causing the check to fail, idk why it's not but fix them anyways. Once that's done and u retest it code tomorrow, we'll merge.

@legoguy1000
Copy link
Member

We need to update the Max Translational and Rotational speeds to what @owenflatman set and bind the spit function to the driver X button.

@txrnqt txrnqt requested a review from legoguy1000 January 15, 2025 22:03
@txrnqt txrnqt merged commit 0eb883a into main Jan 15, 2025
5 checks passed
@txrnqt txrnqt deleted the update branch January 15, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 2024 Robot to WPILIB 2025
3 participants