Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ggplot2 loading to visc_empty skeleton.Rmd #256

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

kelliemac
Copy link
Contributor

@kelliemac kelliemac commented Jan 11, 2025

Description

add ggplot2 loading to visc_empty skeleton.Rmd

Related Issues

addresses #251

Checklist

  • This PR includes unit tests
  • This PR establishes a new function or updates parameters in an existing function
    • The roxygen skeleton for this function has been updated using devtools::document
  • I have updated NEWS.md to describe the proposed changes

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (b8969f4) to head (112d4a8).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #256      +/-   ##
===========================================
- Coverage    82.10%   81.79%   -0.32%     
===========================================
  Files            8        8              
  Lines          352      346       -6     
===========================================
- Hits           289      283       -6     
  Misses          63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelliemac kelliemac self-assigned this Jan 11, 2025
@kelliemac kelliemac requested a review from lemireg January 11, 2025 01:57
@kelliemac kelliemac requested a review from slager January 31, 2025 21:09
@kelliemac
Copy link
Contributor Author

@slager can you review this PR?

@slager
Copy link
Contributor

slager commented Jan 31, 2025

Approved, but noticed typo in skelton

@kelliemac kelliemac merged commit bcc9a0f into develop Feb 4, 2025
6 checks passed
@kelliemac kelliemac deleted the update-package-loading branch February 4, 2025 03:34
@slager
Copy link
Contributor

slager commented Mar 4, 2025

Resolves #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants