Adding all WDL unit tests to API pytests

[tefirman]

Description

• Expanding test-failures.py to include all unit test WDLs to the cromwellapi pytests
• Creating an analogous test-successes.py to check for success from all non-bad unit test WDLs

Related Issues

• Fixes "Bad" and "good" WDLs in API tests #90

Testing

• Updated pytests worked great locally using the Makefile.
• Pushed the new vcr cassettes to this PR.

[tefirman]

@sckott, really hope I didn't duplicate efforts, I should've checked with you first, sorry about that. Mind taking a look?

[sckott]

Will do in the morning

[sckott]

Nice, looks good!

There's some formatting that could be done, but doesn't need to be done here, opened an issue to add a new gh action workflow #104

[tefirman]

Thanks @sckott ! Removing those unused packages, and great call on the new issue with linting/formatting actions, seems like a smart step.

[tefirman]

Now that I look back at test-call.py compared to test-failures.py and test-successes.py, I'm wondering if there's too much overlap, essentially submitting the same jobs twice but checking for slightly different things each time.. Should we think about consolidating those? Or is it better to have the redundancy just in case?

[sckott]

@tefirman

I'm wondering if there's too much overlap, essentially submitting the same jobs twice but checking for slightly different things each time

But I don't think we are

In conftest.py we submit the jobs. In most of the tests, including the ones worked on and referenced here, we just ping the cromwell api to get metadata on the already submitted jobs.

there are a few tests where we submit workflows but i think those are hopefully cases where we need to to do the correct test

[tefirman]

Ahhh, you're totally right @sckott , didn't fully grasp that. So we may have duplicate API metadata calls (which is fine), but the actual workflows only run once during conftest.py, correct?

[sckott]

the actual workflows only run once during conftest.py, correct?

yes