Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring FH-specific unit tests in Cromwell Test Run (starts with "api") #106

Closed
wants to merge 5 commits into from

Conversation

tefirman
Copy link
Collaborator

@tefirman tefirman commented Feb 7, 2025

Description

  • Occasionally, we'll have unit tests that are specific to the FH cluster environment and should only be run via the PROOF API GitHub Action, not the Cromwell Test Run Action (e.g. module and gpus runtime parameters)
  • Excluding WDL unit tests that start with "api" from the Cromwell Test Run GitHub Action
  • Also renaming helloModuleHostname to apiHelloModuleHostname to exclude it accordingly

Related Issues

Testing

  • As seen below, apiHelloModuleHostname only has a WOMtool validation triggered and not a Cromwell test run.
  • Also confirmed locally that apiHelloModuleHostname is still included and pass the API pytests.

@tefirman tefirman marked this pull request as ready for review February 7, 2025 01:29
@tefirman tefirman requested review from sckott and seankross February 7, 2025 01:30
This was referenced Feb 7, 2025
@sckott
Copy link
Collaborator

sckott commented Feb 7, 2025

thinking we wait until conversation is settled in #107 yeah?

@tefirman
Copy link
Collaborator Author

tefirman commented Feb 7, 2025

Holding off on this for now, as it is out of scope for this sprint and requires further discussion amongst the group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude FH-specific unit tests from the Cromwell Test Run Action
2 participants