Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cromwell tests docs in readme #34

Merged
merged 6 commits into from
Jan 23, 2025
Merged

added cromwell tests docs in readme #34

merged 6 commits into from
Jan 23, 2025

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Dec 18, 2024

#33

@sckott sckott requested review from seankross and tefirman December 18, 2024 20:36
README.md Outdated Show resolved Hide resolved
@seankross seankross added the documentation Improvements or additions to documentation label Dec 18, 2024
@sckott sckott mentioned this pull request Dec 19, 2024
11 tasks
@sckott sckott requested a review from seankross January 3, 2025 18:49
@sckott
Copy link
Collaborator Author

sckott commented Jan 3, 2025

@seankross the failing test is unrelated since the only change here is in the readme. can you approve now?

@sckott
Copy link
Collaborator Author

sckott commented Jan 6, 2025

ping @seankross

@seankross
Copy link
Collaborator

@sckott lemme run through this myself locally and then I will approve

@sckott
Copy link
Collaborator Author

sckott commented Jan 7, 2025

@seankross let me know if you run into any issues

@seankross
Copy link
Collaborator

@sckott I just tried to run this and got this error. I likely need to investigate further, maybe my api key isn't right.

ImportError while loading conftest '/Users/skross/Developer/wdl-unit-tests/tests/cromwell-api/conftest.py'.
tests/cromwell-api/conftest.py:8: in <module>
    cromwell_url = proof_api.cromwell_url()
tests/cromwell-api/proof.py:36: in cromwell_url
    self.start_if_not_up()
tests/cromwell-api/proof.py:32: in start_if_not_up
    if not self.is_cromwell_server_up():
tests/cromwell-api/proof.py:22: in is_cromwell_server_up
    return not self.status()["canJobStart"]
E   KeyError: 'canJobStart'

@seankross
Copy link
Collaborator

I tried this with PROOF_API_TOKEN_DEV set in plain text (without using 1pw) and it worked, se we'll need to figure out how to integrate 1pw into this. Let's put this on hold for now though.

@sckott
Copy link
Collaborator Author

sckott commented Jan 16, 2025

@seankross can you try this:

# set the env var
export PROOF_API_TOKEN_DEV="op://Shared/PROOF Test User/dev token"
# check that it's working 
op run --no-masking -- printenv PROOF_API_TOKEN_DEV
# run pytest in the repo
op run -- uv run pytest tests/cromwell-api --verbose

I checked to make sure my env var of the same name was unset in my own dot files, and that the workflows started by the test suite were in fact in the test user account, which they were, so I think this is working "ON MY MACHINE" at least. lemme know howitdo

@seankross
Copy link
Collaborator

That did it! Ugh I didn't read the docs closely enough.

@seankross
Copy link
Collaborator

See #70

@sckott sckott merged commit 4c5dfca into main Jan 23, 2025
17 checks passed
@sckott sckott deleted the apitests-readme-docs branch January 23, 2025 16:36
@sckott
Copy link
Collaborator Author

sckott commented Jan 23, 2025

woops, been a while since this was opened, and need to change some things, will send a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants