Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding module check to HelloModuleHostname #85

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Adding module check to HelloModuleHostname #85

merged 2 commits into from
Feb 6, 2025

Conversation

tefirman
Copy link
Collaborator

Description

  • Adding an assertion to confirm that the appropriate module is loaded in the HelloModuleHostname WDL.

Related Issues

Testing

  • Ran WDL using PROOF, completes successfully
  • Unfortunately won't succeed with local miniwdl run and test run GitHub Action
  • Should only be merged until we sort out how to isolate test runs to PROOF

sitapriyamoorthi
sitapriyamoorthi approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@sitapriyamoorthi sitapriyamoorthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we need to write a test that actually ensure the module is not only loaded properly into the environment but also actually is working!

@sitapriyamoorthi sitapriyamoorthi merged commit 96066d1 into main Feb 6, 2025
18 of 21 checks passed
@sitapriyamoorthi sitapriyamoorthi added the unit test Adding or modifying a unit test label Feb 6, 2025
@tefirman tefirman mentioned this pull request Feb 6, 2025
Closed
@tefirman
Copy link
Collaborator Author

tefirman commented Feb 6, 2025

Shoot, this one wasn't quite ready to merge, I should have switched it to draft, totally my fault. I'll set up another PR to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitapriyamoorthi sitapriyamoorthi sitapriyamoorthi approved these changes

Assignees
No one assigned
Labels
unit test Adding or modifying a unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module usage
2 participants
@tefirman @sitapriyamoorthi