Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve procstat check #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tuxillo
Copy link

@tuxillo tuxillo commented Mar 20, 2020

Use found() method instead of checking for specific headers and symbols.

@tuxillo
Copy link
Author

tuxillo commented Mar 20, 2020

Not sure but I think it's a better way of checking for procstat availability.

@tuxillo
Copy link
Author

tuxillo commented Jan 11, 2021

any feedback? :)

@wulf7
Copy link
Contributor

wulf7 commented Jan 11, 2021

'procstat_open_sysctl' check was done to ensure that libprocstat can use sysctl kernel interface rather than kvm one. But as both interfaces was introduced with the same FreeBSD commit, this check is useless.
IMO we can drop libprocstat support entirely as it was outperformed by evdev sysctl interface. The only thing we should test in that case is webcamd+wayland combination. It may require including a user in to webcamd group to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants