Skip to content

don't try creating existing directories #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release/17.0
Choose a base branch
from
Open

don't try creating existing directories #36

wants to merge 2 commits into from

Conversation

miken32
Copy link
Contributor

@miken32 miken32 commented Apr 2, 2025

The error suppression operator doesn't seem to be working, and is terrible practice anyway. This change prevents warnings showing up in the restore output:

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

PHP Warning: mkdir(): File exists in /var/www/html/admin/modules/voicemail/Restore.php on line 18

@miken32
Copy link
Contributor Author

miken32 commented Apr 2, 2025

Also

PHP Notice: Only variables should be assigned by reference in /var/www/html/admin/modules/voicemail/install.php on line 63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miken32