to_cast is not always talloced

FreeRADIUS · Sep 4, 2023 · 9e0fa80 · 9e0fa80
1 parent 54b71c9
commit 9e0fa80
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/lib/redis/redis.c b/src/lib/redis/redis.c
@@ -281,7 +281,8 @@ int fr_redis_reply_to_value_box(TALLOC_CTX *ctx, fr_value_box_t *out, redisReply
 		if (shallow) {
 			fr_value_box_bstrndup_shallow(to_cast, NULL, reply->str, reply->len, true);
 		} else {
-			if (fr_value_box_bstrndup(to_cast, to_cast, NULL, reply->str, reply->len, true) < 0) return -1;
+			if (fr_value_box_bstrndup(to_cast->talloced ? to_cast : ctx, to_cast, NULL,
+						  reply->str, reply->len, true) < 0) return -1;
 		}
 		break;