only free the the vp on the error path

if the first byte is non-zero, then the result is non-zero, and we don't need to check it on all paths
FreeRADIUS · Sep 8, 2023 · f6b6d23 · f6b6d23
1 parent c2080c5
commit f6b6d23
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/protocols/dhcpv4/packet.c b/src/protocols/dhcpv4/packet.c
@@ -147,8 +147,9 @@ int fr_dhcpv4_decode(TALLOC_CTX *ctx, fr_pair_list_t *out, uint8_t const *data,
 
 				q = memchr(p, '\0', dhcp_header_sizes[i]);
 				fr_pair_value_bstrndup(vp, (char const *)p, q ? q - p : dhcp_header_sizes[i], true);
+			} else {
+				TALLOC_FREE(vp);
 			}
-			if (vp->vp_length == 0) TALLOC_FREE(vp);
 			break;
 
 			/*