Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changes to achieve 100% coverage #161

Closed
wants to merge 6 commits into from
Closed

Remove changes to achieve 100% coverage #161

wants to merge 6 commits into from

Conversation

kar-rahul-aws
Copy link
Member

@kar-rahul-aws kar-rahul-aws commented May 13, 2024

Description

This PR removes changes in source code , introduced in #146 to achieve 100% branch coverage.

Test Steps

cmake -S .. -B build
make coverage

Before applying the patch

                       |Lines       |Functions  |Branches
Filename        |Rate     Num|Rate    Num|Rate     Num
=========================================================
core_json.c     | 100%    554| 100%    35| 99.50%    601
=========================================================
     Total:     | 100%    554| 100%    35| 100%      604

After applying the patch

                       |Lines       |Functions  |Branches
Filename        |Rate     Num|Rate    Num|Rate     Num
======================================================
core_json.c     | 100%    588| 100%    35| 100%    596
======================================================
     Total:     | 100%    588| 100%    35| 100%    596

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws marked this pull request as draft May 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant