Skip to content
This repository has been archived by the owner on May 28, 2022. It is now read-only.

Added outline of new database scheme and TODO list #680

Closed

Conversation

SRomansky
Copy link
Contributor

WIP Database scheme refactoring

Related #484
Related #671

SRomansky pushed a commit to SRomansky/freeseer that referenced this pull request Dec 18, 2014
UNIQUE (Speaker, Title) ON CONFLICT IGNORE)'''



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8 violation here, too many blank lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Forgot to flake8.

@dideler dideler added this to the 2014 Fall - UCOSP milestone Dec 19, 2014
@dideler
Copy link
Member

dideler commented Dec 19, 2014

Is this okay to merge now or are you still working on this PR?

@SRomansky
Copy link
Contributor Author

Still working on it, I think after the ON CONFLICT is updated it can be merged?
Was Speaker, Title, and Event the combination that made the most sense for the ON CONFLICT, or should the code give the user some sort of warning when a conflict occurs?

@dideler
Copy link
Member

dideler commented Dec 19, 2014

@wigglier for now just do the combination of Speaker, Title, and Event.

@SRomansky
Copy link
Contributor Author

OK, added and updated the TODO's to reflect the change.

@SRomansky
Copy link
Contributor Author

Added them in. Also added a TODO for updating the upgrade path to support 310 to 315 as well.

@dideler
Copy link
Member

dideler commented Dec 19, 2014

Merged as 645adc8, thanks.

@dideler dideler closed this Dec 19, 2014
@SRomansky SRomansky deleted the refactor-database-scheme branch December 19, 2014 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants