Skip to content

Commit

Permalink
Merge pull request #84 from FriedRiceNoodles/fix/issue#79
Browse files Browse the repository at this point in the history
fix(progress): progress backgroundColor attributes named to backgroun…
  • Loading branch information
FriedRiceNoodles authored Mar 21, 2024
2 parents 3c67e17 + 4a9d6ee commit 373442b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .changeset/breezy-swans-bow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@banana-ui/banana': patch
'@banana-ui/react': patch
---

progress backgroundColor attributes named to background-color
6 changes: 4 additions & 2 deletions packages/banana/src/progress/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('b-progress', () => {
});

it('when provided a backgroundColor parameter', async () => {
const element = await fixture<BProgress>(html`<b-progress backgroundColor="red"></b-progress>`);
const element = await fixture<BProgress>(html`<b-progress background-color="red"></b-progress>`);
const progressElement = element.shadowRoot?.querySelector('.progress') as HTMLElement;
let backgroundColor = window.getComputedStyle(progressElement).backgroundColor;

Expand Down Expand Up @@ -119,7 +119,9 @@ describe('b-progress', () => {
});

it('custom border radius', async () => {
const element = await fixture<BProgress>(html`<b-progress style="--banana-progress-border-radius: 2px"></b-progress>`);
const element = await fixture<BProgress>(
html`<b-progress style="--banana-progress-border-radius: 2px"></b-progress>`,
);
const progressElement = element.shadowRoot?.querySelector('.progress') as HTMLElement;
const innerElement = element.shadowRoot?.querySelector('.progress-bar') as HTMLElement;
const progressBorderRadius = window.getComputedStyle(progressElement).borderRadius;
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 373442b

Please sign in to comment.