Clean up mess around mdanter/ecc fork and CVE-2024-33851 #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5955016. The CVE id is for a follow up advisory
Needs to cover both mdanter/ecc and paragonie/ecc
xabbuh
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
#719 - multiple security issues in mdanter/ecc lead to fork in paragonie/ecc and I requested they fill in the CVE id when they have one. I then changed the advisory to include a CVE id in #722
However it turns out there are really two separate advisories:
So I've reverted the addition of the CVE id to the original advisory, and then added new advisories with the CVE id for the second issue on both packages now.