Add fallbackToSmaxage flag to CustomTtlListener and check for isCacheable before calling store #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
patch-1
branch
from
389d421 to
1aa6b86
Compare
alexander-schranz
force-pushed
the
patch-1
branch
from
cfe0a4a to
bc3874c
Compare
dbu
changed the title
dbu
reviewed
Jul 23, 2024
There was a problem hiding this comment.
thanks. we can do the extra flag - though setting custom ttl to 0 should have the same effect.
can you explain the flag in the documentation as well, please?
https://github.com/FriendsOfSymfony/FOSHttpCache/blob/3.x/doc/symfony-cache-configuration.rst#custom-ttl
Co-authored-by: David Buchmann <[email protected]>
dbu
reviewed
Jul 23, 2024
dbu
reviewed
Jul 23, 2024
Co-authored-by: David Buchmann <[email protected]>
Co-authored-by: David Buchmann <[email protected]>
dbu
reviewed
Jul 23, 2024
dbu
reviewed
Jul 23, 2024
Co-authored-by: David Buchmann <[email protected]>
dbu
reviewed
Jul 23, 2024
dbu
reviewed
Jul 23, 2024
alexander-schranz
changed the title
Merged
1 task
Co-authored-by: David Buchmann <[email protected]>
dbu
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Only call store when response still is cacheable * Add flag to disable fallback to s-maxage to changelog
|
squashed and merged as 6957dee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the
CustomTtlListenerenabled but we have controllers which set only as-maxagethes-maxageis in our case always only for browsers and should never used by Symfony or Varnished HttpCache / reverse proxy.The current
CustomTtlListenerstill fallbacks always back to s-maxage / maxage this should in my opinion not the case ifCustomTtlListenerthe HttpCache should only listen on the configured header and ignore the max age headers./cc @Toflar @dbu Alternativily we should also add a option to the
CustomTtlListenerdisableFallback/enableFallback.Update
As discussed below we will add additional
fallbackToSmaxage = trueparameter to make it possible to disable that fallback mechanism.Additional this pull request adds a recheck for
$response->isCachableafter the listeners were run. That not only improve performance for response setting a ttl to 0 but its now possible to set a response to private in a preHandle listener event to also disable the caching.