Workaround phpstan analysis error

Doctrine hints ObjectRepository when DocumentRepository or EntityRepository is expected
FriendsOfSymfony · Feb 1, 2018 · 48bf733 · 48bf733
1 parent 6975461
commit 48bf733
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/Document/TokenManager.php b/Document/TokenManager.php
@@ -14,6 +14,7 @@
 namespace FOS\OAuthServerBundle\Document;
 
 use Doctrine\ODM\MongoDB\DocumentManager;
+use Doctrine\ODM\MongoDB\DocumentRepository;
 use FOS\OAuthServerBundle\Model\TokenInterface;
 use FOS\OAuthServerBundle\Model\TokenManager as BaseTokenManager;
 
@@ -74,8 +75,10 @@ public function deleteToken(TokenInterface $token)
      */
     public function deleteExpired()
     {
-        $result = $this
-            ->dm->getRepository($this->class)
+        // NOTE: bug in Doctrine, hinting DocumentRepository|ObjectRepository when only DocumentRepository is expected
+        /** @var DocumentRepository $repository */
+        $repository = $this->em->getRepository($this->class);
+        $result = $repository
             ->createQueryBuilder()
             ->remove()
             ->field('expiresAt')->lt(time())

diff --git a/Entity/TokenManager.php b/Entity/TokenManager.php
@@ -14,6 +14,7 @@
 namespace FOS\OAuthServerBundle\Entity;
 
 use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\EntityRepository;
 use FOS\OAuthServerBundle\Model\TokenInterface;
 use FOS\OAuthServerBundle\Model\TokenManager as BaseTokenManager;
 
@@ -74,7 +75,10 @@ public function deleteToken(TokenInterface $token)
      */
     public function deleteExpired()
     {
-        $qb = $this->em->getRepository($this->class)->createQueryBuilder('t');
+        // NOTE: bug in Doctrine, hinting EntityRepository|ObjectRepository when only EntityRepository is expected
+        /** @var EntityRepository $repository */
+        $repository = $this->em->getRepository($this->class);
+        $qb = $repository->createQueryBuilder('t');
         $qb
             ->delete()
             ->where('t.expiresAt < ?1')