[ci] added php84 #334
Closed
[ci] added php84 #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhu
force-pushed
the
feature/php84-gha-testing
branch
from
da73ff2 to
f65f6ae
Compare
|
php 8.4 is planned for December 2024 😅 I had to check! :) Would be cool to mark php 8.4 pipeline as "allowed to fail" on the CI, wdyt? |
@thePanz Absolutely! I'll look into how to do that. |
connorhu
force-pushed
the
feature/php84-gha-testing
branch
from
f65f6ae to
c4addcc
Compare
|
Meanwhile, php 8.4 has landed. Maybe it's time for updating and merging this pr? |
|
PR #382 is now merged, closing this one |
|
This whole thing pisses me off, but since it's open source I guess it's the way it's supposed to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets see this.