[BUGFIX] Make preview renderer compatible with v12.4.17 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2024
o-ba
approved these changes
Jul 9, 2024
saschanowak
approved these changes
Jul 9, 2024
o-ba
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Actually using different implementations for the versions might be better, because now we again have a different method signature when using tt_address with TYPO3 < 12.4.17. However due to the default value (null) this won't trigger the exception and should be sufficient for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TYPO3 v12.4.17 the method
StandardContentPreviewRenderer::renderContentElementPreviewFromFluidTemplatehas been changed. This PR makes theTtAddressPreviewRenderercompatible again.