Skip to content

Commit

Permalink
Change description flag depth in TxPool (#2387)
Browse files Browse the repository at this point in the history
## Linked Issues/PRs
Resolves #2313

## Description

This PR add more description to a flag we keep with a bad name for
backward compatibility purposes.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)

---------

Co-authored-by: Green Baneling <[email protected]>
  • Loading branch information
AurelienFT and xgreenx authored Jan 27, 2025
1 parent 902f772 commit be4ca87
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased]

### Changed
- [2387](https://github.com/FuelLabs/fuel-core/pull/2387): Update description `tx-max-depth` flag.
- [2630](https://github.com/FuelLabs/fuel-core/pull/2630): Removed some noisy `tracing::info!` logs

### Fixed
Expand Down
1 change: 1 addition & 0 deletions bin/fuel-core/src/cli/run/tx_pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ pub struct TxPoolArgs {
#[clap(long = "tx-max-total-bytes", default_value = "131072000", env)]
pub tx_max_total_bytes: usize,

/// The flag name is `tx-max-depth` for backward compatibility but the behavior is:
/// The max number of tx in a chain of dependent transactions that supported by the `TxPool`.
#[clap(long = "tx-max-depth", default_value = "32", env)]
pub tx_max_chain_count: usize,
Expand Down

0 comments on commit be4ca87

Please sign in to comment.