Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that fuel-core lib builds correctly without default features #2594

Merged
merged 6 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ jobs:
args: -p fuel-core-chain-config --target wasm32-unknown-unknown --no-default-features
- command: check
args: -p fuel-core-executor --target wasm32-unknown-unknown --no-default-features --features alloc
- command: check
args: -p fuel-core --no-default-features
rymnc marked this conversation as resolved.
Show resolved Hide resolved
fail-fast: false

# disallow any job that takes longer than 45 minutes
Expand Down
1 change: 1 addition & 0 deletions ci_checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ cargo check -p fuel-core-storage --target wasm32-unknown-unknown --no-default-fe
cargo check -p fuel-core-client --target wasm32-unknown-unknown --no-default-features &&
cargo check -p fuel-core-chain-config --target wasm32-unknown-unknown --no-default-features &&
cargo check -p fuel-core-executor --target wasm32-unknown-unknown --no-default-features --features alloc &&
cargo check -p fuel-core --no-default-features &&
rymnc marked this conversation as resolved.
Show resolved Hide resolved
cargo make check --all-features --locked &&
cargo make check --locked &&
OVERRIDE_CHAIN_CONFIGS=true cargo test --test integration_tests local_node &&
Expand Down
1 change: 1 addition & 0 deletions crates/fuel-core/src/combined_database.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ pub struct CombinedDatabaseConfig {
pub database_type: DbType,
#[cfg(feature = "rocksdb")]
pub database_config: DatabaseConfig,
#[cfg(feature = "rocksdb")]
pub state_rewind_policy: StateRewindPolicy,
}

Expand Down
12 changes: 5 additions & 7 deletions crates/fuel-core/src/database.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ pub use fuel_core_database::Error;
pub type Result<T> = core::result::Result<T, Error>;

// TODO: Extract `Database` and all belongs into `fuel-core-database`.
use crate::database::database_description::{
gas_price::GasPriceDatabase,
indexation_availability,
};
#[cfg(feature = "rocksdb")]
use crate::state::{
historical_rocksdb::{
Expand All @@ -75,17 +79,11 @@ use crate::state::{
StateRewindPolicy,
},
rocks_db::{
ColumnsPolicy,
DatabaseConfig,
RocksDb,
},
};
use crate::{
database::database_description::{
gas_price::GasPriceDatabase,
indexation_availability,
},
state::rocks_db::ColumnsPolicy,
};
#[cfg(feature = "rocksdb")]
use std::path::Path;

Expand Down
Loading