Fix version compatibility error #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
AurelienFT
added
the
no changelog
acerone85
reviewed
Jan 21, 2025
acerone85
reviewed
Jan 21, 2025
acerone85
previously approved these changes
Jan 21, 2025
This was referenced Jan 21, 2025
Closed
netrome
previously approved these changes
Jan 21, 2025
rymnc
reviewed
Jan 21, 2025
version-compatibility/Cargo.toml
Outdated
|
|
||
| # Remove when we upgrade rust version | ||
| [patch.crates-io] | ||
| netlink-proto = { git = "https://github.com/rust-netlink/netlink-proto", tag = "v0.11.3" } |
There was a problem hiding this comment.
will we be able to release to crates.io with a patch like this? curious
There was a problem hiding this comment.
No, we can't. Can we create an issue in the repository related to the crate? And on our side for now just to use old version explicitly?
There was a problem hiding this comment.
I changed on our side. Why do you want to create an issue on their repo to tell them that they increased MRSV in the last patch release ?
There was a problem hiding this comment.
If it was done in the minor release, then they need to revert it and create a new major release
xgreenx
approved these changes
Jan 21, 2025
acerone85
approved these changes
Jan 21, 2025
Merged
MitchTurner
added a commit
that referenced
this pull request
Jan 22, 2025
## Version v0.41.1 * fault_proving(compression): include block_id in da compressed block headers by @rymnc in #2551 * chore: Add myself and Andrea as codeowner for graphql API + related crates by @netrome in #2570 * fix(integration_tests): remove flake from produce_block__l1_committed_block_affects_gas_price by @rymnc in #2566 * bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis better by @MitchTurner in #2599 * Fix version compatibility error by @AurelienFT in #2608 * Improve error messages for responses from committer by @MitchTurner in #2609 * Update async processor tests by @rafal-ch in #2577 * The amount of returned dust coins is limited by factor relative to the amount of selected big coins by @rafal-ch in #2610 * fix(da_compression): invalid decompression of utxo id and CoinConfig fix by @rymnc in #2593 * Use latest gas price to estimate next price for tx pool checks by @MitchTurner in #2612 * Set Latest Recorded Height on startup by @MitchTurner in #2603 * Use latest gas price to estimate next block gas price during dry runs by @MitchTurner in #2615 * Check that fuel-core lib builds correctly without default features by @rafal-ch in #2594 * Expose indexation status in `NodeInfo` endpoint by @rafal-ch in #2595 **Full Changelog**: v0.41.0...v0.41.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in version compatibility, waiting for #2607
Checklist
Before requesting review