Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forc-client build script should update proxy abi also for deployment tests #6561

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

kayagokalp
Copy link
Member

Description

closes #6558.

This PR fixes an issue with the forc-client build script that causes the deployment tests to be updated manually for each proxy abi change. This is a follow up on #6535 and was overlooked in that one. Not critical as it does not break anything on the user side but rather an code-quality issue.

@kayagokalp kayagokalp added bug Something isn't working code quality forc-client Everything related to the `forc-client` crate. labels Sep 18, 2024
@kayagokalp kayagokalp self-assigned this Sep 18, 2024
@kayagokalp kayagokalp requested a review from a team as a code owner September 18, 2024 06:05
@kayagokalp kayagokalp enabled auto-merge (squash) September 18, 2024 06:05
@JoshuaBatty JoshuaBatty requested a review from a team September 18, 2024 22:25
@kayagokalp kayagokalp merged commit 613f129 into master Sep 19, 2024
39 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/6558 branch September 19, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality forc-client Everything related to the `forc-client` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forc-client build script should also update proxy abi for the tests
3 participants