Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace mp3 with ogg and proper filetype recognition #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Actiol
Copy link

@Actiol Actiol commented Nov 14, 2024

Replaced the sped up audio filetype with ogg using an ffmpeg wrapper since its better in quality with lower filesize and also has consistent offset unlike mp3 making timing way more accurate (low quality will now be 128bkps and high quality 192kbps)

I also fixed the filetype recognition to actually read the filetype rather than assuming the extension is accurate. (It's a bit janky with little and big endian but it works). Example map for when this would cause issues: https://osu.ppy.sh/beatmapsets/1347975

i had to update to fsharp 9 from 8 for it to work.
vs added some system references by itself, idk why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant