Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package mindep into a folder #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Package mindep into a folder #4

wants to merge 1 commit into from

Conversation

rht
Copy link
Contributor

@rht rht commented Feb 23, 2017

If mindep is an experiment (among more other experiments) on cliqs.

@rht rht force-pushed the mindep branch 3 times, most recently from f2d07de to 7b52315 Compare February 23, 2017 18:58
@Futrell
Copy link
Owner

Futrell commented Feb 23, 2017

mindep and opt_mindep are more support code for run_mindep which is the actual experiment. I'd like to keep folder structure relatively flat for this small project.

I've been thinking about reorganizing this thing into a package cliqs, with run_mindep and possibly other experiments as separate executables that import the package. This would resolve various dependency resolution issues that people have. Just so you know that is coming, and please advise if you foresee problems.

@rht
Copy link
Contributor Author

rht commented Feb 23, 2017

I see, right, what I had in mind was if run_mindep could be renamed to run_exp mindep. mindep could be decoupled from the cliqs repo once there is one more cross-linguistics exp (which could be similar to mindep at first).

I'm also wondering if deptransform.py could be melded into depgraph.py (the former contains various operation utils on DepSentence), DepSentence in readcorpora.py also moved to depgraph.py[1].

This would resolve various dependency resolution issues that people have.

I could fix these -- if one of the issues are py2/py3 (so far I had encountered the issues with relative import on py3) futurize -w . should solve it, though there might be memory issues as the generators are going to be converted to lists.

(heads up incoming PRs on cliqs: parallel map fix, and caching of the corpora (as of now I have to download the dataset every time))

[1] I had been reviewing this against various existing implementations of parse tree (so far in py ecosystem, nltk.parse.dependencygraph, and spaCy's, and later on corenlp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants