This repository has been archived by the owner on May 13, 2019. It is now read-only.
Add BETWEEN SQL operator #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
- Coverage 73.56% 73.4% -0.16%
=========================================
Files 26 25 -1
Lines 3038 3016 -22
Branches 421 425 +4
=========================================
- Hits 2235 2214 -21
- Misses 662 663 +1
+ Partials 141 139 -2
Continue to review full report at Codecov.
|
marcoceppi
force-pushed
the
feature/between
branch
5 times, most recently
from
a606f2b to
65c3609
Compare
|
I'm definitely sure you could merge the logic of both classes into one - have a BetweenBase or similar, which uses a class attribute to define if it's BETWEEN or NOT BETWEEN, and inject the right version in during generate_sql of the parent class. |
|
I very well almost did that. I'll update the PR |
marcoceppi
force-pushed
the
feature/between
branch
from
65c3609 to
4268672
Compare
|
I've updated the PR using a |
* Creates `BetweenBase` orm.operators * Creates `Between` and `NotBetween` orm.operators * Adds `isin` operators to schema.column * Adds `nbetween` operator to schema.column * Adds `between` operator to schema.column
marcoceppi
force-pushed
the
feature/between
branch
from
4268672 to
ccc4042
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty clumsy stab at Between, which I'd like to use over the excessive
>=/<=queries. I also took the liberty to patch a minor annoyance of theInoperator not being available onorm.schema.column.ColumnI'm open to feedback, I couldn't really find another good example for generating a sql statement based on two explicit values without adding 3x the lines of code.
Finally, I opt'd for
NotBetweeninstead of the existingNBetween- between is already long, adding two more characters didn't seem like much of an advantage. I did use thenbetweenon the column - like I said, this is just a clumsy fumble through a patch.TODO: