Added test for domain_ownership logic

app/lib/services/domain_ownership_service.rb

@@ -8,6 +8,7 @@ def authorize!(identity, cert_req)
                                 (domain.group_delegation &&
                                 (domain.groups & identity.groups).any?))
       end
+      nil
     end
 
     private

app/models/domain_info.rb

@@ -4,5 +4,5 @@ class DomainInfo
 
   attribute :owner, :string
   attribute :groups, array: :string, default: []
-  attribute :group_delegation, :bool, default: false
+  attribute :group_delegation, :boolean, default: false
 end

test/lib/services/domain_ownership_service_test.rb

@@ -0,0 +1,46 @@
+require "test_helper"
+
+class DomainOwnershipServiceTest < ActiveSupport::TestCase
+  def setup
+    @identity = Identity.new(subject: "[email protected]", groups: ["admin_group"])
+    @domain = DomainInfo.new(owner: "[email protected]", group_delegation: false, groups: ["admin_group"])
+  end
+
+  test "#authorize! with matching owner" do
+    ds = Services::DomainOwnershipService.new
+    ds.stub :get_domain_name, @domain do
+      assert_nil(ds.authorize!(@identity, CertIssueRequest.new))
+    end
+  end
+
+  test "#authorize! with non-matching owner" do
+    ds = Services::DomainOwnershipService.new
+    @domain.owner = "[email protected]"
+    ds.stub :get_domain_name, @domain do
+      assert_raises(AuthError) do
+        ds.authorize!(@identity, CertIssueRequest.new)
+      end
+    end
+  end
+
+  test "#authorize! with matching group" do
+    ds = Services::DomainOwnershipService.new
+    @domain.owner = "[email protected]"
+    @domain.group_delegation = true
+    ds.stub :get_domain_name, @domain do
+      assert_nil(ds.authorize!(@identity, CertIssueRequest.new))
+    end
+  end
+
+  test "#authorize! with non-matching group" do
+    ds = Services::DomainOwnershipService.new
+    @domain.owner = "[email protected]"
+    @identity.groups = ["different_group"]
+    ds.stub :get_domain_name, @domain do
+      assert_raises(AuthError) do
+        ds.authorize!(@identity, CertIssueRequest.new)
+      end
+    end
+  end
+
+end

test/models/cert_isssue_request_test.rb

@@ -70,7 +70,6 @@ def setup
     assert_not @cert_issue_request.valid?
   end
 
-
   test "fqdns should return alt_names plus common_name" do
     assert_equal [ "alt1.example.com", "alt2.example.com", "example.com" ], @cert_issue_request.fqdns
   end

test/test_helper.rb

@@ -1,6 +1,8 @@
 ENV["RAILS_ENV"] ||= "test"
 require_relative "../config/environment"
 require "rails/test_help"
+require "minitest"
+require "minitest/mock"
 
 module ActiveSupport
   class TestCase