Compact logging payload, rename AuthorizeRequest ->

AuthorizeCertRequest for logging clarity

app/interactors/audit_logging.rb

@@ -21,8 +21,9 @@ def log
       result: result,
       error: context.error&.message,
       subject: context.identity&.subject,
-      cert_common_name: context.request&.try(:common_name)
-    }
+      cert_common_name: context.request&.try(:common_name),
+      kv_path: context.request&.try(:kv_path)
+    }.compact!
     AuditLogger.new.send(level, payload)
   end
 end

app/interactors/authorize_request.rb → app/interactors/authorize_cert_request.rb

@@ -1,4 +1,4 @@
-class AuthorizeRequest
+class AuthorizeCertRequest
   include Interactor
   include FailOnError
   include AuditLogging

app/interactors/issue_cert.rb

@@ -2,5 +2,5 @@ class IssueCert
   include Interactor::Organizer
   include FailOnError
 
-  organize RefreshDomain, AuthorizeRequest, ObtainCert
+  organize RefreshDomain, AuthorizeCertRequest, ObtainCert
 end

app/lib/requests/secret_request.rb

@@ -5,6 +5,7 @@ class SecretRequest
 
     attribute :path, :string
     attribute :data
+    alias_attribute :kv_path, :path
 
     validates :path, presence: true
   end

app/lib/services/vault_service.rb

@@ -32,6 +32,7 @@ def client
       end
 
       def enable_engine(mount, type)
+        # create the engine mount if not present already
         unless client.sys.mounts.key?(mount.to_sym)
           client.sys.mount(mount, type, "#{type} secrets engine")
         end

test/integration/certificates_test.rb

@@ -1,7 +1,7 @@
 require "test_helper"
 
 class CertificatesTest < ActionDispatch::IntegrationTest
-  test "#create unauthorized" do
+  test "#create with missing token" do
     post certificates_path
     assert_response :unauthorized
   end

test/interactors/authorize_request_test.rb → test/interactors/authorize_cert_request_test.rb

@@ -1,11 +1,11 @@
 require "test_helper"
 
-class AuthorizeRequestTest < ActiveSupport::TestCase
+class AuthorizeCertRequestTest < ActiveSupport::TestCase
   def setup
     @domain = domains(:group_match)
     @identity = Identity.new(subject: @domain.users_array.first)
     @cr = Requests::CertIssueRequest.new(common_name: @domain.fqdn)
-    @interactor = AuthorizeRequest
+    @interactor = AuthorizeCertRequest
   end
 
   test ".call with matching owner" do